Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus metrics for monitoring #110

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Add prometheus metrics for monitoring #110

wants to merge 36 commits into from

Conversation

aditya1702
Copy link
Contributor

@aditya1702 aditya1702 commented Jan 24, 2025 •
edited
Loading

What

  • Start separate prometheus servers for api and ingest services. Note that while the prometheus servers are separate, the metrics are collected on the same grafana server.
  • Collect db metric stats using the sqlstats library.
  • Add metrics for ingestion service.

Why

We want to setup a proper monitoring framework for the wallet-backend.

Known limitations

NA

Issue that this PR addresses

Closes #99

Checklist

PR Structure

  • It is not possible to break this PR down into smaller PRs.
  • This PR does not mix refactoring changes with feature changes.
  • This PR's title starts with name of package that is most changed in the PR, or all if the changes are broad or impact many packages.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • All updated queries have been tested (refer to this check if the data set returned by the updated query is expected to be same as the original one).

Release

  • This is not a breaking change.
  • This is ready to be tested in development.
  • The new functionality is gated with a feature flag if this is not ready for production.

@aditya1702 aditya1702 marked this pull request as ready for review January 24, 2025 21:43
gouthamp-stellar
gouthamp-stellar reviewed Jan 31, 2025
View reviewed changes
internal/db/db.go Outdated Show resolved Hide resolved
gouthamp-stellar
gouthamp-stellar reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@gouthamp-stellar gouthamp-stellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this pr capturing all the metrics listed in the https://docs.google.com/document/d/1xx0srb5MnVaK4x8cjQniauKsDroKEzL841yVmBfXYZk/edit?tab=t.0#heading=h.5lnmdqf1727m or is that coming in a future pr?

@aditya1702
Copy link
Contributor Author

Is this pr capturing all the metrics listed in the https://docs.google.com/document/d/1xx0srb5MnVaK4x8cjQniauKsDroKEzL841yVmBfXYZk/edit?tab=t.0#heading=h.5lnmdqf1727m or is that coming in a future pr?

@gouthamp-stellar Yes due to lot of metrics, I will break it into smaller PRs

gouthamp-stellar
gouthamp-stellar reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@gouthamp-stellar gouthamp-stellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more changes I pointed out that would be nice to make here

@aditya1702 aditya1702 changed the title Add prometheus monitoring for DB and ingestion Add prometheus metrics for monitoring Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristidesstaffieri aristidesstaffieri Awaiting requested review from aristidesstaffieri

@gouthamp-stellar gouthamp-stellar Awaiting requested review from gouthamp-stellar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EPIC] Implement grafana integration in the wallet backend
2 participants
@aditya1702 @gouthamp-stellar